Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GHA] Update actions/checkout v3 -> v4 #14704

Merged
merged 1 commit into from
Sep 20, 2024
Merged

[GHA] Update actions/checkout v3 -> v4 #14704

merged 1 commit into from
Sep 20, 2024

Conversation

sionescu
Copy link
Contributor

V3 runs on a deprecated version of Node.js (16) and Github has now started forcing Node.js 20.

@sionescu
[GHA] Update actions/checkout v3 -> v4
58fd689 
V3 runs on a deprecated version of Node.js (16) and Github has now
started forcing Node.js 20.
@sionescu sionescu requested a review from a team as a code owner September 20, 2024 16:56
@trunk-io Trunk.io
Copy link

trunk-io bot commented Sep 20, 2024 •
edited
Loading

⏱️ 2h 7m total CI duration on this PR
Job Cumulative Duration Recent Runs
execution-performance / single-node-performance 22m 🟩 
forge-compat-test / forge 18m 🟩 
forge-e2e-test / forge 15m 🟩 
rust-move-unit-coverage 15m 🟩 
prover-inconsistency-test 10m 🟥 
rust-move-tests 9m 🟩 
run-all-circuit-tests 5m 🟩 
rust-doc-tests 5m 🟩 
execution-performance / test-target-determinator 5m 🟩 
test-target-determinator 4m 🟩 
check 4m 🟩 
build 2m 🟥 
check-dynamic-deps 2m 🟩 🟩 
general-lints 2m 🟩 
rust-cargo-deny 2m 🟩 
indexer-grpc-e2e-tests / test-indexer-grpc-docker-compose 2m 🟩 
determine-test-metadata 1m 🟩 
determine-test-metadata 1m 🟩 
determine-test-metadata 1m 🟩 
semgrep/ci 50s 🟩 🟩 
file_change_determinator 19s ⬜ 🟩 
file_change_determinator 10s 🟩 
file_change_determinator 10s 🟩 
Backport PR 9s 🟥 🟥 
permission-check 6s 🟩 🟩 
determine-test-metadata 6s 🟩 
permission-check 6s 🟩 🟩 
permission-check 5s 🟩 🟩 
permission-check 5s 🟩 🟩 
permission-check 5s 🟩 🟩 
permission-check 2s 🟩 
determine-docker-build-metadata 2s 🟩 
rust-move-tests 1s ⬜ 

settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io

@sionescu sionescu added the CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR label Sep 20, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@codecov Codecov
Copy link

codecov bot commented Sep 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.8%. Comparing base (ce6158a) to head (58fd689).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##             main   #14704     +/-   ##
=========================================
- Coverage    59.8%    59.8%   -0.1%     
=========================================
  Files         851      851             
  Lines      207415   207415             
=========================================
- Hits       124221   124184     -37     
- Misses      83194    83231     +37
Flag Coverage Δ
59.8% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 58fd6892992bf63814e2ac977ec7ca706704e278

two traffics test: inner traffic : committed: 14243.41 txn/s, latency: 2787.89 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3300 ms), latency samples: 5415760
two traffics test : committed: 99.89 txn/s, latency: 1800.66 ms, (p50: 1500 ms, p70: 1600, p90: 1700 ms, p99: 9900 ms), latency samples: 1820
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.245, avg: 0.230", "QsPosToProposal: max: 1.107, avg: 1.091", "ConsensusProposalToOrdered: max: 0.323, avg: 0.296", "ConsensusOrderedToCommit: max: 0.414, avg: 0.399", "ConsensusProposalToCommit: max: 0.711, avg: 0.695"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.82s no progress at version 2319350 (avg 0.21s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.52s no progress at version 2319348 (avg 8.52s) [limit 15].
Test Ok

@github-actions GitHub Actions
Copy link
Contributor

✅ Forge suite compat success on 25a081116546670e62ca927ba90478de78557056 ==> 58fd6892992bf63814e2ac977ec7ca706704e278

Compatibility test results for 25a081116546670e62ca927ba90478de78557056 ==> 58fd6892992bf63814e2ac977ec7ca706704e278 (PR)
1. Check liveness of validators at old version: 25a081116546670e62ca927ba90478de78557056
compatibility::simple-validator-upgrade::liveness-check : committed: 14694.99 txn/s, latency: 2261.95 ms, (p50: 2100 ms, p70: 2200, p90: 3100 ms, p99: 5500 ms), latency samples: 486140
2. Upgrading first Validator to new version: 58fd6892992bf63814e2ac977ec7ca706704e278
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7714.82 txn/s, latency: 3517.42 ms, (p50: 3800 ms, p70: 4300, p90: 4500 ms, p99: 4600 ms), latency samples: 137440
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7658.86 txn/s, latency: 4124.17 ms, (p50: 4200 ms, p70: 4400, p90: 6100 ms, p99: 6500 ms), latency samples: 257060
3. Upgrading rest of first batch to new version: 58fd6892992bf63814e2ac977ec7ca706704e278
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7329.67 txn/s, latency: 3848.80 ms, (p50: 4200 ms, p70: 4400, p90: 4600 ms, p99: 4800 ms), latency samples: 140420
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6752.31 txn/s, latency: 4324.83 ms, (p50: 4600 ms, p70: 4700, p90: 4800 ms, p99: 5800 ms), latency samples: 256380
4. upgrading second batch to new version: 58fd6892992bf63814e2ac977ec7ca706704e278
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 11881.94 txn/s, latency: 2287.71 ms, (p50: 2500 ms, p70: 2600, p90: 2700 ms, p99: 2800 ms), latency samples: 207500
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 11862.82 txn/s, latency: 2667.69 ms, (p50: 2600 ms, p70: 2700, p90: 3300 ms, p99: 4400 ms), latency samples: 386500
5. check swarm health
Compatibility test for 25a081116546670e62ca927ba90478de78557056 ==> 58fd6892992bf63814e2ac977ec7ca706704e278 passed
Test Ok

@sionescu sionescu merged commit 109814a into main Sep 20, 2024
125 of 138 checks passed
@sionescu sionescu deleted the stelian/update-checkout-action branch September 20, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rustielin rustielin rustielin approved these changes

@JoshLind JoshLind JoshLind approved these changes

@perryjrandall perryjrandall Awaiting requested review from perryjrandall

Assignees
No one assigned
Labels
CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sionescu @JoshLind @rustielin